Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELEMENTS-1677: build failed while generating a snapshot for elements project #817

Closed
wants to merge 1 commit into from
Closed

ELEMENTS-1677: build failed while generating a snapshot for elements project #817

wants to merge 1 commit into from

Conversation

rahuljain-dev
Copy link
Contributor

@rahuljain-dev rahuljain-dev commented Oct 3, 2023 •
edited
Loading

https://jira.nuxeo.com/browse/ELEMENTS-1677
(backward port)

Issue raised in lerna repo:
lerna/lerna#3854

@rahuljain-dev rahuljain-dev requested a review from a team as a code owner October 3, 2023 06:35
@rahuljain-dev rahuljain-dev force-pushed the fix-ELEMENTS-1677-build-failed-while-generating-a-snapshot-for-elements-project-3.0.x branch 14 times, most recently from cf247ed to 1eab33a Compare October 3, 2023 09:19
@rahuljain-dev rahuljain-dev requested review from arupmmi07, rakeshkumar1019 and poonamyadav252 and removed request for Nisha-QA and Pranit-Sotre October 3, 2023 09:22
rakeshkumar1019
rakeshkumar1019 previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@rakeshkumar1019 rakeshkumar1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.Just add the PR raised in lerna repo of this issue for future reference.

poonamyadav252
poonamyadav252 reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@poonamyadav252 poonamyadav252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to see story books checks here.

@rahuljain-dev
Copy link
Contributor Author

Looks good.Just add the PR raised in lerna repo of this issue for future reference.
added

@rahuljain-dev rahuljain-dev reopened this Oct 3, 2023
@rahuljain-dev
Copy link
Contributor Author

I am not able to see story books checks here.

which story book checks?

@poonamyadav252
Copy link
Contributor

I am not able to see story books checks here.

which story book checks?

https://github.com/nuxeo/nuxeo-elements/actions/runs/6391071771/job/17345592528?pr=813

@rahuljain-dev rahuljain-dev force-pushed the fix-ELEMENTS-1677-build-failed-while-generating-a-snapshot-for-elements-project-3.0.x branch 2 times, most recently from 6a7293b to 0c52d44 Compare October 3, 2023 09:47
@rahuljain-dev rahuljain-dev force-pushed the fix-ELEMENTS-1677-build-failed-while-generating-a-snapshot-for-elements-project-3.0.x branch from 0c52d44 to 83ca95e Compare October 3, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poonamyadav252 poonamyadav252 poonamyadav252 left review comments

@rakeshkumar1019 rakeshkumar1019 rakeshkumar1019 left review comments

@arupmmi07 arupmmi07 Awaiting requested review from arupmmi07

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahuljain-dev @poonamyadav252 @rakeshkumar1019